fix: re-initialize DOM subscriptions from a full snapshot on cdp reconnect #29210
+24
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtofStryker
reviewed
Mar 27, 2024
Co-authored-by: Bill Glesias <bglesias@gmail.com>
AtofStryker
approved these changes
Mar 27, 2024
cacieprins
approved these changes
Mar 28, 2024
1 flaky test on run #54716 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| ... > dismisses the banner for a specified time |
Test Replay
Screenshots
|
|
Review all test suite changes for PR #29210 ↗︎
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
This issue occurs when CDP disconnects for some reason. On reconnect, we try to reestablish subscriptions, etc. We do call
DOM.enable, but unfortunately the disconnect wipes out all of our DOM tracking that we've done thus far. The best way to fix this is on a reconnect, we should just capture a full snapshot from scratch.PR Tasks
cypress-documentation?type definitions?